Expose path and version in outputs
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way it follows the standard way used also by official gh-actions such as setup-java
|
|
alessio-perugini
added
type: enhancement
alessio-perugini
approved these changes
Sep 8, 2023
alessio-perugini
changed the title
path and version in outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Declare outputs
pathandversionThat way it follows the standard way used also by official gh-actions such as setup-java:
https://github.com/actions/setup-java/blob/main/action.yml#L71
How was it tested ?
I tested it here:
https://github.com/sebastienvermeille/another-protobuf-maven-plugin/blob/feature/rework-it-tests/.github/workflows/build.yml#L30
And the execution is here:
https://github.com/sebastienvermeille/another-protobuf-maven-plugin/actions/runs/6112694628/job/16590954927#step:7:1
Please let me know if something more is required from my side 👍 happy to contribute :)